Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map): Codegen for PlantUML Target #73

Merged
merged 5 commits into from
Nov 22, 2023
Merged

feat(map): Codegen for PlantUML Target #73

merged 5 commits into from
Nov 22, 2023

Conversation

jonathan-casey
Copy link
Member

@jonathan-casey jonathan-casey commented Nov 16, 2023 •
edited
Loading

Sample

Screenshot 2023-11-21 at 12 14 36

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@jonathan-casey
feat(*): extend plantuml visitor
cd6ed99 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
test(*): add test cov
8383e6d 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
test(*): update snapshot
fa55c17 
Signed-off-by: Jonathan Casey <[email protected]>
@coveralls
Copy link

coveralls commented Nov 16, 2023 •
edited
Loading

Coverage Status

coverage: 98.918% (+0.001%) from 98.917%
when pulling 1fd3269 on jonathan/codegen_map_plantuml
into e22a321 on main.

@jonathan-casey
feat(*): uses associate array
e136f65 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey
test(*): snapshot update
1fd3269 
Signed-off-by: Jonathan Casey <[email protected]>
@jonathan-casey jonathan-casey marked this pull request as ready for review November 17, 2023 11:22
@jonathan-casey jonathan-casey requested a review from a team November 17, 2023 11:24
@mttrbrts
Copy link
Member

@jonathan-casey There appear to be two edges for employeeDirectory in the screenshot. Is that expected?

@jonathan-casey
Copy link
Member Author

You can ignore that, it was an additional association added while tinkering in planttext. Screenshot updated.

@jonathan-casey jonathan-casey merged commit 717194d into main Nov 22, 2023
11 checks passed
@jonathan-casey jonathan-casey deleted the jonathan/codegen_map_plantuml branch November 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanblaginov stefanblaginov stefanblaginov approved these changes

@ekarademir ekarademir ekarademir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathan-casey @coveralls @mttrbrts @ekarademir @stefanblaginov